Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync typeshed #17124

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Sync typeshed #17124

merged 4 commits into from
Apr 15, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Sync typeshed

Source commit:
python/typeshed@7c8e82f

Note that you will need to close and re-open the PR in order to trigger CI.

mypybot and others added 4 commits April 15, 2024 01:09
This is allegedly causing large performance problems, see 13821

typeshed/8231 had zero hits on mypy_primer, so it's not the worst thing
to undo. Patching this in typeshed also feels weird, since there's a
more general soundness issue. If a typevar has a bound or constraint, we
might not want to solve it to a Literal.

If we can confirm the performance regression or fix the unsoundness
within mypy, I might pursue upstreaming this in typeshed.

(Reminder: add this to the sync_typeshed script once merged)
Copy link
Contributor Author

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@JelleZijlstra JelleZijlstra merged commit 5161ac2 into master Apr 15, 2024
18 checks passed
@JelleZijlstra JelleZijlstra deleted the mypybot/sync-typeshed branch April 15, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants